Fix #769 - Correctly indicate probe error to user #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the only check was whether a test was complete, not whether it was at all successful. After redirect to the result page, we then presented the most recent result for each probe, which could silently return results from the distant past.
mxsasha
added a commit
that referenced
this pull request
Dec 13, 2022
Before this change, the only check was whether a test was complete, not whether it was at all successful. After redirect to the result page, we then presented the most recent result for each probe, which could silently return results from the distant past. There may still be some cases where test error handling is not optimal, but those should be loud, which means #770 will notify us. (cherry picked from commit 10ec9b0)
mxsasha
added a commit
that referenced
this pull request
Dec 20, 2022
Before this change, the only check was whether a test was complete, not whether it was at all successful. After redirect to the result page, we then presented the most recent result for each probe, which could silently return results from the distant past. There may still be some cases where test error handling is not optimal, but those should be loud, which means #770 will notify us. (cherry picked from commit 10ec9b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the only check was whether a test was complete,
not whether it was at all successful. After redirect to the result
page, we then presented the most recent result for each probe,
which could silently return results from the distant past.
There may still be some cases where test error handling is not optimal,
but those should be loud, which means #770 will notify us.