Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON data for response #25

Closed
vohmar opened this issue Mar 28, 2018 · 2 comments
Closed

Use JSON data for response #25

vohmar opened this issue Mar 28, 2018 · 2 comments

Comments

@vohmar
Copy link
Contributor

vohmar commented Mar 28, 2018

Drop text source of Unix whois reqests and use JSON instead.

There are two version of whois data for every active domain registration in whois db - in json and in text form. Latter is used by unix whois for very quick responses. But the maintenance overhead to keep this going does not seem to justify the effort.. For this reason we would like to drop the text verision of whois response snapshots and proceed with only json version of whois data.

@artur-intech
Copy link
Contributor

artur-intech commented Mar 29, 2018

internetee/registry#375

@maciej-szlosarczyk
Copy link
Contributor

This has slightly wider implications, as plain unix body is used also by rest-whois. Instead of generating a template, we traverse each line of whois_record's body and base the response on that. This also needs to be revamped.

https://github.com/internetee/rest-whois/blob/master/app/models/whois_record.rb#L12-L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants