Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp WHOIS generation #375

Open
artur-intech opened this issue Feb 20, 2017 · 5 comments
Open

Revamp WHOIS generation #375

artur-intech opened this issue Feb 20, 2017 · 5 comments
Assignees

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Feb 20, 2017

Current issues:

  • WHOIS part needs refactoring
  • Registry APP is responsible for presentation, therefore every WHOIS record must be regenerated if output format is updated (currently it is performed manually by running rake task)
  • Martin:

whois que job was made to address this problems, but they are still there
eg. 1 domain will get update and whois data must be updated too
for some reason if technical contact is reused and is linked to many domasin
all this domains will get whois update even if update has nothing todo with tech contact
elkdata is reusing their technical contact with many domais
and if one of this domains got whois update, it took up to 15 min!

Martin:
registry db:

there are only domains from domains table, not domains from blocked and reserved tables
json column is for restful whois other one is for unix whois
#327

registrar whois update triggers %w(name email phone street city state zip) are probably outdated

@artur-intech artur-intech self-assigned this Feb 20, 2017
@artur-intech
Copy link
Contributor Author

artur-intech commented Feb 20, 2017

Martin about the table in registry db:

there are only domains from domains table, not domains from blocked and reserved tables @

whois for sure is not using it
and no other process will need this data
i mean whois and rest whois bot use whois database, not table in registry database where only partial info is present

@artur-intech
Copy link
Contributor Author

artur-intech commented Feb 20, 2017

@ratM1n @teadur FYI

@teadur
Copy link
Contributor

teadur commented Mar 24, 2017

I think when revamping the whois generation, #325 should be considered aswell

@artur-intech
Copy link
Contributor Author

artur-intech commented Mar 29, 2018

I would first check what causes slowdowns mentioned above. Perhaps it's worth considering some nosql solution, since the data we have at the moment does not seem to be relational at all.

whois_records table structure:
id | name | body | json | created_at | updated_at

@artur-intech
Copy link
Contributor Author

artur-intech commented Nov 1, 2018

Another problem:

https://github.com/internetee/registry/blob/a0c880151b0ef5dd8069a184758d4652ea3e2540/db/whois_schema.rb

is now out of sync with

https://github.com/internetee/rest-whois/blob/811abc9611dc02eea691812efae84936cb1df970/db/schema.rb

and the former cannot be removed from registry project since some tests and/or code (see Whois::Record uses) rely on it.
In turn, rest-whois project requires the latter schema, therefore some additional effort is needed to make them both work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants