Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to create contact with punnycode #2609

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Unable to create contact with punnycode #2609

merged 3 commits into from
Aug 23, 2023

Conversation

OlegPhenomenon
Copy link
Contributor

@OlegPhenomenon OlegPhenomenon commented Aug 22, 2023 •
edited
Loading

What's the problem?

  • One of our clients is complaining that his email with a valid punnycode does not pass validation when creating a contact.

What's the solution?

  • I added an additional method that parses the email's hostname and converts it to UTF format. After which, the transformed hostname is then checked by Truemail.

How to test?

  • Ensure that valid emails with a standard hostname are being created.
  • Ensure that valid emails with punnycode are being created.
  • Ensure that invalid emails can't be created.
  • Ensure that invalid emails with punnycode can't be created.

How to review?

  • Check the code's frequency.
  • Ensure the code doesn't complicate the logic.

@viezly
Copy link

viezly bot commented Aug 22, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@vohmar vohmar merged commit 5fc8bc9 into master Aug 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maricavor maricavor maricavor approved these changes

Assignees

@vohmar vohmar

Labels
enhancement
Projects
No open projects
.ee registry system
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegPhenomenon @maricavor @vohmar