Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby to 2.5 #846

Closed
9 tasks done
maciej-szlosarczyk opened this issue May 9, 2018 · 3 comments
Closed
9 tasks done

Update Ruby to 2.5 #846

maciej-szlosarczyk opened this issue May 9, 2018 · 3 comments

Comments

@maciej-szlosarczyk
Copy link
Contributor

maciej-szlosarczyk commented May 9, 2018

Continuation of #546. Should be done before December 2018 when 2.6 is scheduled to be released.

To upgrade to 2.5, we need:

@maciej-szlosarczyk maciej-szlosarczyk self-assigned this Jun 29, 2018
artur-intech pushed a commit that referenced this issue Feb 28, 2019
1.2.0 support Ruby 2.5
ruby-grape/grape#1813

#846
@teadur teadur assigned teadur and unassigned maciej-szlosarczyk Aug 19, 2019
@teadur teadur added the blocked label Sep 4, 2019
@teadur
Copy link
Contributor

teadur commented Sep 4, 2019

As of Rails 4.2 is not tested against Ruby 2.5 by upstream ( https://travis-ci.org/rails/rails/builds/516718585 ) we should not consider it supported by Rails 4.2.

Same goes for Rails 5.0 ( https://travis-ci.org/rails/rails/builds/516718340 )
First rails version what is tested against ruby 2.5 is 5.1 ( https://travis-ci.org/rails/rails/builds/516044024 )

If possible (we have enough time before Ruby 2.4 end of security support 2020-03)
We should try to upgrade to Rails 5.1 before upgrading Ruby.

If we get time constrained we should upgrade Ruby before getting to Rails 5.1
So for now blocked by #377

@teadur
Copy link
Contributor

teadur commented Jan 28, 2020

PG gem needs to be upgraded with rails 5.1 #896

@vohmar
Copy link
Contributor

vohmar commented Feb 5, 2020

rails raised to 5.1.7
ruby to 2.6.3

closed by #1495

@vohmar vohmar closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants