Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace discarded term in code with delete candidate #825

Open
vohmar opened this issue Apr 18, 2018 · 1 comment
Open

replace discarded term in code with delete candidate #825

vohmar opened this issue Apr 18, 2018 · 1 comment
Labels

Comments

@vohmar
Copy link
Contributor

vohmar commented Apr 18, 2018

There is a term discarded used in the code to mark domains that have deleteCandidate status set. As discarded term is not used anywhere in the business processes it creates a confusion about meaning of it.

It is a good practice to use same terminology in software as is used in business processes. Therefore term discarded should be replaced with delete candidate term as this is one that is used to describe domains waiting for the deletion to happen.

introduced with: #789

@vohmar vohmar added the bug label Apr 18, 2018
@artur-intech
Copy link
Contributor

artur-intech commented Apr 18, 2018

This is not a bug. The naming was my decision as a part of my job to accomplish the task I have been assigned. If you're not happy with the terms, it would be great to hear your questions and suggestions (about naming).

Anyway, below I explained why this name was needed.

#784 (comment)
#790 (comment)
#792 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants