Consider renaming "deleteCandidate" status of a domain

[artur-intech]

@vohmar Is there any reason why "candidate" word is used in deleteCandidate status? I didn't notice any circumstances under which a domain with that status does not get permanently deleted, so why to call it a candidate?

[vohmar]

deleteCandidate status is removable in admin
deleteCandidate means that the domain object in waiting to be deleted/archived/released thus it is candidate (it is not deleted yet)

no renaming necessary - consider unifying the term in code as well (using deleteCandidate universally)

[artur-intech]

"not yet deleted" has nothing in common with the word "candidate". As I understand it, candidate implies that

a person or thing regarded as suitable for or likely to receive a particular fate, treatment, or position.

, but I cannot find any circumstances under which a domain will not be deleted. Please point me to that part.

I think "discard" is a more suitable word to model this business logic. If you want to revert it, you could "keep" that domain.

Currently this status is set by a CRON job

registry/app/models/domain_cron.rb

Line 112 in c1cb598

domain.statuses << DomainStatus::DELETE_CANDIDATE

How exactly is possible to remove that status from a domain in admin area?

In general, I think it's worth changing our mindset from just operating with the statuses of a domain to operations with a domain. Say, instead of saying "add deleteCandidate status to a domain" you say "discard that domain" or instead of "add archived status" just "archive that domain". I consider status as a pure implementation detail.

[vohmar]

we have decided not to proceed with renaming any statuses nor changing processes at the moment.