-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directo: directos.request empty for credit invoices #344
Comments
Why Directo requests are saved? |
we also have log everything policy (we log every request coming in or going out from the registry). This is mainly for debugging, problem solving and proving what was sent out from the registry in case there is some doubt. |
@vohmar FYI: It is actually vice-versa: monthly invoice requests are not saved |
@vohmar What do you think, if instead of that "directos" and any other possible table we create some single audit log table and collect there everything that is really important for us to log (who did what and when)? We could store, for example:
Communication with third-party services like Directo and Äriregister might also be logged there.
Worth noting: I don't suggest this as a replacement for application log (Rails.logger, syslog as a backend on prod). That part remains as is for now. It is more like a high-level audit log. Some kind of activity log. I don't think creating a new storage (=table) for every new thing that needs to leave some trail is a good idea. |
lets continue with directos for now and come back to this question with "papertrail"/"log and versioning" refactoring. There are two separate types of "logs" - versioning and action logs. These should be handled together if we change anything. |
registry saves the XML sent to directo in the directos.request column. It has values only for monthly invoices, for credit loading invoices it is empty.
The text was updated successfully, but these errors were encountered: