-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended price lookup policy #313
Comments
artur-intech
changed the title
Registration period and price list management
Improve price list management
Jun 14, 2017
artur-intech
changed the title
Improve price list management
Add new price lookup policy
Jun 29, 2017
artur-intech
changed the title
Add new price lookup policy
Add extended price lookup policy
Jun 30, 2017
artur-intech
pushed a commit
that referenced
this issue
Aug 22, 2017
artur-intech
pushed a commit
that referenced
this issue
Aug 23, 2017
Merged
artur-intech
pushed a commit
that referenced
this issue
Sep 1, 2017
artur-intech
pushed a commit
that referenced
this issue
Sep 1, 2017
artur-intech
pushed a commit
that referenced
this issue
Sep 1, 2017
artur-intech
pushed a commit
that referenced
this issue
Sep 17, 2017
artur-intech
pushed a commit
that referenced
this issue
Oct 12, 2017
Check "operation_category" conversion |
artur-intech
pushed a commit
that referenced
this issue
Oct 12, 2017
artur-intech
pushed a commit
that referenced
this issue
Oct 16, 2017
artur-intech
pushed a commit
that referenced
this issue
Oct 16, 2017
artur-intech
pushed a commit
that referenced
this issue
Oct 16, 2017
artur-intech
pushed a commit
that referenced
this issue
Oct 16, 2017
How that validation should look like? Do you want a calendar or some list which will show prices that will expire soon? |
Also, can you define sortable fields that we really need? Given the changes where multiple zones/operations/periods allowed, it makes no sense to sort. Perhaps you want to add period range filter? |
Prod queries:
|
|
artur-intech
pushed a commit
that referenced
this issue
Oct 19, 2017
|
artur-intech
pushed a commit
that referenced
this issue
Oct 21, 2017
- Remove domain period and period unit - Allow multiple price operation categories and durations #313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Starting from 1st of May .ee will have minimum 3 month registrations on one end 10 year max registrations at the other. That means 13 different pricelist entries per paied operation. As there are two at the moment for .ee and 5 zones that makes the number of entries to manage 130. This is error prone and therefore current solution is not sufficient.
To solve the problem there should be a model to derive the price from other price list entries if the specific operation, period and zone is missing (ie if entry for 10y registration is missing 1y price is used and multiplied by 10 to get the effective price)
No changes are needed in /admin/prices for price list entry creation and update for this solution. The logic to find the price is done on registry server level.
Logic: hierarchy based price finding process.
hierarchy1: zone and sub-zones - for example .pri.ee is sub-zone of .ee or .pri.ee is parent zone to .example.pri.ee zone. So if there is no required price specified in the zone look for the prices in parent zone.
hierarhy2: operations - create is the base operation. ie if renew is paied operation and it is missing specific pricelist entry, look for the price for create operation. For example renew request for 3 years - if specific price list entry is missing look for the create price for the 3 years
hierarchy3: periods - 1 year is base for any longer full year periods. For example 10 year create request - if specific price list entry is missing for this period look for the 1 year period and multiply it by 10 to get the price for 10 years.
base price for shorter periods than a year is 1 month
full hierarchy:
1y tld create (base) > 1y tld renew > Ny tld create > Ny tld renew > 1y sld create > 1y sld renew etc
Ny - stands for longer periods than 1y ie 2y, 5y, 10y
sld - second/sub level domain. The logic must be extendable to third and fourth level domains as well in case these are managed by the regsitry.
Example: 4y renew request for example.pri.ee domain. There is only 1y create price of 1€ under .ee zone in the price list. The process to have the price for this example is following
Look for the price of 4y renew for pri.ee - 4y renew for pri.ee - 1y renew for pri.ee - 1y create for pri.ee - 4y renew for .ee - 4y create for .ee - 1y renew for .ee - 1y create for .ee (bingo). 1y create price for .ee is taken multiplied by 4 and the price for the example request is 4€.
If a price to use is not found return error 2104 "Billing failure: price not found"
for short term registrations and renewals the base price should be 1m.
The current process does not support odd periods longer than one year ie 18m
admin: /admin/settings
/admin/prices
The text was updated successfully, but these errors were encountered: