fixed tests

internetee · Oct 19, 2023 · ca9b37c · ca9b37c
1 parent faa4dea
commit ca9b37c
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/app/models/dns/domain_name.rb b/app/models/dns/domain_name.rb
@@ -71,7 +71,7 @@ def reserved?
     end
 
     def bsa_protected?
-      BsaProtectedDomain.where(name: name).any?
+      BsaProtectedDomain.where(domain_name: name).any?
     end
 
     def disputed?

diff --git a/app/services/bsa/application_service.rb b/app/services/bsa/application_service.rb
@@ -32,9 +32,9 @@ def struct_response(response)
       parsed_data = parse_response(response)
       result = [OK, ACCEPTED].include? response.code
 
-      Struct.new(:result?, :error).new(result, OpenStruct.new(parsed_data)) unless result
+      return Struct.new(:result?, :error).new(result, OpenStruct.new(parsed_data)) unless result
 
-      if  parsed_data.is_a?(Array)
+      if parsed_data.is_a?(Array)
         Struct.new(:result?, :body).new(result, parsed_data.map { |data| OpenStruct.new(data) })
       else
         Struct.new(:result?, :body).new(result, OpenStruct.new(parsed_data))

diff --git a/app/services/bsa/block_order_list_service.rb b/app/services/bsa/block_order_list_service.rb
@@ -19,7 +19,6 @@ def initialize(sort_by:, order:, offset:, limit:, q:)
 
     def call
       http = connect(url: base_url)
-
       response = http.get(endpoint, headers.merge(token_format(token)))
 
       struct_response(response)

diff --git a/test/services/bsa/block_order_list_service_test.rb b/test/services/bsa/block_order_list_service_test.rb
@@ -1,6 +1,6 @@
 require 'test_helper'
 
-RESPONSE = {
+RESPONSE_BLOCK_ORDER_LIST_SERVICE = {
   "list": [
     {
       "blockSubOrderId": 690_680_666_563_633,
@@ -71,13 +71,14 @@ def test_for_succesfull_block_order_list
     stub_request(:get, 'https://api-ote.bsagateway.co/bsa/api/blockrsporder')
       .to_return(
         status: 200,
-        body: RESPONSE.to_json,
+        body: RESPONSE_BLOCK_ORDER_LIST_SERVICE.to_json,
         headers: { 'Content-Type' => 'application/json' }
       )
 
     r = Bsa::BlockOrderListService.call
 
     assert r.result?
+
     assert_equal r.body.list.count, 2
   end
 
@@ -103,7 +104,7 @@ def test_parse_query_parameters
 
     result = instance_serive.send(:query_string)
 
-    assert_equal result, 'sortBy=createdAt&order=desc&offset=0&limit=100&tld=test'
+    assert_equal result, 'sortBy=createdBy&order=desc&offset=0&limit=100&q=tld%3Dtest'
   end
 
   private

diff --git a/test/services/bsa/block_order_view_service_test.rb b/test/services/bsa/block_order_view_service_test.rb
@@ -2,7 +2,7 @@
 
 require 'test_helper'
 
-RESPONSE = {
+RESPONSE_BLOCK_VIEW_SERVICE = {
   "list": %w[
     label1
     label2
@@ -32,7 +32,7 @@ def test_for_succesfull_block_order_list
     stub_request(:get, 'https://api-ote.bsagateway.co/bsa/api/blockrsporder/labels?blocksuborderid=1')
       .to_return(
         status: 200,
-        body: RESPONSE.to_json,
+        body: RESPONSE_BLOCK_VIEW_SERVICE.to_json,
         headers: { 'Content-Type' => 'application/json' }
       )
 

diff --git a/test/services/bsa/download_non_blocked_name_list_service_test.rb b/test/services/bsa/download_non_blocked_name_list_service_test.rb
@@ -2,7 +2,7 @@
 
 require 'test_helper'
 
-RESPONSE = 'some,csv,data'
+RESPONSE_DOWNLOAD = 'some,csv,data'
 
 class Bsa::BlockOrderViewServiceTest < ActiveSupport::TestCase
   setup do
@@ -19,15 +19,15 @@ def test_for_succesfull_downloaded_non_blocked_name
     stub_request(:get, 'https://api-ote.bsagateway.co/bsa/api/blockrsporder/1/nonblockednames')
       .to_return(
         status: 200,
-        body: RESPONSE.to_json,
+        body: RESPONSE_DOWNLOAD.to_json,
         headers: { 'Content-Type' => 'text/csv',
                    'Content-Disposition' => 'attachment; filename="mock-csv.csv"' }
       )
 
     result = Bsa::DownloadNonBlockedNameListService.call(suborder_id: 1, filename: @filename)
 
     assert File.exist?("#{@filename}.csv")
-    assert_equal RESPONSE, File.read("#{@filename}.csv").gsub('"', '')
+    assert_equal RESPONSE_DOWNLOAD, File.read("#{@filename}.csv").gsub('"', '')
     assert result.result?
     assert_equal "Data was added to #{@filename}.csv file", result.body.message
   end