-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feat: Add Bulk Import UI for lists #11700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
395ShikharSingh
wants to merge
6
commits into
internetarchive:master
Choose a base branch
from
395ShikharSingh:feature/import-by-url
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat: Add Bulk Import UI for lists #11700
395ShikharSingh
wants to merge
6
commits into
internetarchive:master
from
395ShikharSingh:feature/import-by-url
+837
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
for more information, see https://pre-commit.ci
… standardizing styles with Less variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
…efore bulk import processing.
for more information, see https://pre-commit.ci
…efore bulk import processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
Closes #11672
Summary
This PR implements a new Bulk Import feature that allows users to add multiple books to a list by:
Files Changed
openlibrary/plugins/upstream/account.pybulk_importroute class for/account/import/bulkopenlibrary/templates/account/import_bulk.htmlstatic/css/page-import-bulk.lessstatic/bookmarklets/isbn_importer_prototype.jsFunction Reference
Core ISBN/Edition Functions
fetchWithProxy(url)extractIsbns(text)isValidIsbn(isbn)lookupEditions(isbns)editionKey,title,coverIdimportBooksFromUrl(url)importBooksFromIsbns(input)List Management Functions
getLoggedInUsername()/accountredirect or parsing pagefetchUserLists(username)/people/{username}/lists.jsoncreateList(username, name, description)/people/{username}/listsaddEditionsToList(listKey, editions){listKey}/seeds.jsonOrchestration Functions (Console Usage)
importAndAddToList(url, listName)importAndAddToExistingList(url, listKey)showMyLists()Screenshots
Screen.Recording-1.mov
Screen.Recording-2.mov
Note: I couldn’t test this URL feature locally, but I tested it on https://openlibrary.org/, and it worked.
Screen.Recording-3.mov
Stakeholders
@mekarpeles