Skip to content

Orphaned editions passed to MergeUI crashing script #11702

@mheiman

Description

@mheiman

Problem

MergeUI will crash if passed orphaned editions that have an authors field. The merge process doesn't actually care, but the enhancement that was added to display author names doesn't take into account the different authors field structures between works and editions.

Reproducing the bug

Here's an example of a merge that crashes the interface:

https://openlibrary.org/works/merge?records=OL14857756W,OL24198259M

You can see the errors in the console.

Context

  • Browser (Chrome, Safari, Firefox, etc): N/A
  • OS (Windows, Mac, etc): N/A
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

All that's required is adding code to handle the difference in author data between works and editions. I'll be making a pull request shortly.

Stakeholders

@mheiman


Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs: BreakdownThis big issue needs a checklist or subissues to describe a breakdown of work. [managed]Needs: LeadNeeds: TriageThis issue needs triage. The team needs to decide who should own it, what to do, by when. [managed]Type: BugSomething isn't working. [managed]

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions