Don't extract data URIs #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ato
force-pushed
the
dont-extract-data-uris
branch
from
305b263
to
b95cda2
Compare
Data URIs can be very large. ExtractorHTML mostly works with off-heap CharSequences so by delaying the conversion of outlinks to strings until after filtering out data URIs we can potentially avoid some very large String allocations.
ato
force-pushed
the
dont-extract-data-uris
branch
from
b95cda2
to
33a5d70
Compare
|
Looks fine. Good catch on the extractors bypassing "the" extractor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #422 by changing the outlink helper methods in the Extractor base class to ignore data URIs. Since data URIs can be very large this also tries to avoid copying them to the heap as Strings when possible.