Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 63.81% 65.18% +1.37%
==========================================
Files 69 69
Lines 6256 6205 -51
Branches 1391 1383 -8
==========================================
+ Hits 3992 4045 +53
+ Misses 2225 2117 -108
- Partials 39 43 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
schu96
force-pushed
the
annotation-merge
branch
2 times, most recently
from
June 18, 2026 02:44
cc2e50c to
274ddda
Compare
cdrini
reviewed
Jul 4, 2026
cdrini
left a comment
cdrini
left a comment
Contributor
There was a problem hiding this comment.
Got through the first half ; will finish the rest later today!
schu96
force-pushed
the
annotation-merge
branch
2 times, most recently
from
July 13, 2026 03:21
b205c70 to
1ac3b87
Compare
schu96
force-pushed
the
annotation-merge
branch
from
August 8, 2026 22:03
467afe4 to
2ed063b
Compare
schu96
force-pushed
the
annotation-merge
branch
from
August 18, 2026 19:11
3f9114e to
ae15b93
Compare
Fix renamed parameter within markRange function
schu96
force-pushed
the
annotation-merge
branch
from
September 10, 2026 20:14
2855f69 to
a738684
Compare
cdrini
reviewed
Sep 10, 2026
| if (!this.activeHighlightNodes) { // highlight selection if not already done | ||
| this.handleHighlightSave(); | ||
| } | ||
| this.br.plugins.textSelection?.textSelectionManager.showAnnotationModal(this.activeHighlightNodes, anchorEl); |
Contributor
There was a problem hiding this comment.
I think we need to create the plugin annotations class matching the other plugins, so that we can attach the annotation-specific methods/data/logic to that alone.
That also keeps/fulfills the promise of BR plugins being optional. Letting people load the plugin files only if they support/want to support the associated functionality.
Suggested change
| this.br.plugins.textSelection?.textSelectionManager.showAnnotationModal(this.activeHighlightNodes, anchorEl); | |
| this.br.plugins.annotations.showAnnotationModal(this.activeHighlightNodes, anchorEl); |
| endTextNode.parentElement.classList.contains("BRhighlight")) { | ||
| return; | ||
| const existingMarks = []; | ||
| const walker = document.createTreeWalker( |
Contributor
There was a problem hiding this comment.
Is there anyway we can re-use some of the helper methods we have? Not sure.
Contributor
|
UI feedback:
|
schu96
marked this pull request as ready for review
September 17, 2026 21:23
Co-Authored-By: Sandy Chu <sandy.chu.40@gmail.com>
Co-authored-by: Sandy Chu <schu96@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated annotation code to work with newly improved main branch