Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bandcamp parser, refactor naming, add type to parse answer #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

4www
Copy link
Contributor

@4www 4www commented Jan 15, 2019

Ref: internet4000/radio4000#296

In this PR:

  • refactor naming: it is more clear what the functions do, parse, instead of just getting the id.
  • type to parse answer: when a url is parsed, it also give a type to the media delivered by this specific provider. For now it is thought as respecting the naming offered by the provider, staying agnostic from media type uniformization (for now at least)
  • add bandcamp parser: pass a bandcamp album or track url and it will be parsed to give an id and a type.
{
  url: 'https://iliantape.bandcamp.com/album/it039-andrea-forse',
  provider: 'bandcamp',
  id: 'it039-andrea-forse',
  type: 'album'
}
{
  url: 'https://iliantape.bandcamp.com/track/future-atmo',
  provider: 'bandcamp',
  id: 'future-atmo',
  type: 'track'
}

Not sure what anyone will use that for, but at least it is there and is ready to be used to some applications.

Note: the same way we could add soundcloud, spotify, vimeo etc.

@4www 4www requested a review from oskarrough January 20, 2019 08:51
Copy link
Member

@oskarrough oskarrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

main.js Show resolved Hide resolved
main.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants