Use a page reader for every "show" commands on dell powerconnect #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 nice job to refactor the pagereader. |
mat128
reviewed
Nov 15, 2016
| self.shell_mock.should_receive("send_key").with_args("m", wait_for=("--More-- or (q)uit", "#"), include_last_line=True).once().ordered().and_return([ | ||
| "line3", | ||
| "line4", | ||
| "--More-- or (q)uit" |
There was a problem hiding this comment.
Isnt there one more blank line before/after this prompt?
There was a problem hiding this comment.
the shell client never returns blank lines
|
inline comment + failing tests, but good job on the PageReader |
Any show command can have pagination so now they will all be run in a page reader that abstracts the pagination A test in the dell10g suite was fixed because it didn't reflect reality: a dell10g won't show pagination Fixes internap#178
lindycoder
force-pushed
the
use_page_reader
branch
from
e9d6ae5 to
b812219
Compare
|
comments answered and texts fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any show command can have pagination so now they will all be run
in a page reader that abstracts the pagination
Fixes #178