Skip to content

return a 404 when no place is found #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2025
+16 −0
Merged

return a 404 when no place is found #181

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb76141
return a 404 when no place is found
drewda Aug 18, 2025
130d1dd
trying again
drewda Aug 18, 2025
442793d
Merge branch 'main' into place-404
irees Nov 3, 2025
bc2ca4d
Update check for typescript rewrite
irees Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/runtime/components/places.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@
import { computed, ref, watch } from 'vue'
import { gql } from 'graphql-tag'
import { useQuery } from '@vue/apollo-composable'
// @ts-ignore - #imports is a Nuxt virtual module
import { createError } from '#imports'

// Types
interface PlaceResponse {
Expand Down Expand Up @@ -191,6 +193,20 @@ const { result, loading } = useQuery<{ places: PlaceResponse[] }>(

const places = computed<Place[]>(() => result.value?.places || [])

// Watch for empty places and throw 404 error
watch([places, loading], ([newPlaces, isLoading]) => {
// Only check after loading is complete and if we have query filters
if (!isLoading && (props.adm0 || props.adm1 || props.city)) {
if (newPlaces.length === 0) {
throw createError({
statusCode: 404,
statusMessage: 'Place not found',
fatal: true
})
}
}
})

const placeTitleName = computed<string>(() => {
if (props.city && props.adm1 && props.adm0) {
return `${props.city}, ${props.adm1}, ${props.adm0}`
Expand Down