Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mi/2961/docker compose #3027

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs: Mi/2961/docker compose #3027

wants to merge 4 commits into from

Conversation

hajjimo
Copy link
Contributor

@hajjimo hajjimo commented Oct 10, 2024

Checklist

  • Related issues linked using fixes #2961
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@hajjimo hajjimo requested a review from mkurapov October 10, 2024 10:39
@github-actions github-actions bot added the pkg: documentation Changes in the documentation package. label Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 682066b
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6710fd4c676f400008d712ab
😎 Deploy Preview https://deploy-preview-3027--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hajjimo hajjimo linked an issue Oct 11, 2024 that may be closed by this pull request

### Domain and subdomains setup

We will map the [Open Payments resource server](/integration/services/backend-service#open-payments) to your domain, and the [ILP Connector](/integration/services/backend-service#interledger-connector), [Open Payments auth server](/integration/services/auth-service), and [Admin UI](/integration/services/frontend-service) to subdomains. Using the DNS host of your choice, set up your domain and subdomains according to the following convention:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(recommended) convention


```sh

server_name admin.myrafiki.com;
server {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
server {
server {

Comment on lines 15 to 20
| service | URL | example |
| ----------------------------- | ------------ | ------------------ |
| Open Payments resource server | DOMAIN | myrafiki.com |
| ILP Connector | ilp.DOMAIN | ilp.myrafiki.com |
| Open Payments auth server | auth.DOMAIN | auth.myrafiki.com |
| Admin UI | admin.DOMAIN | admin.myrafiki.com |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we outline briefly what each of these exposed ports do, or do you think this is enough?


### Open Payments Resource Server (`backend` package)

Using the editor of your choice, save the following file as `oprs.config` in the `/etc/nginx/sites-available` directory on your VM:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oprs.config maybe can be more descriptive? also maybe can match the auth file name as well


### VM specifications

This example deployment uses the `e2-standard-2` VM on <LinkOut href='https://cloud.google.com/compute/docs/general-purpose-machines#e2_machine_types'>Google Cloud Platform</LinkOut> with the following specifications:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this, maybe instead of specifying a specific cloud provider we can say something generic like, "a general-purpose VM with 4GB memory (I think 4GB should be enough actually) and 2 vCPUs should be capable of running the Rafiki software via docker."

Comment on lines 109 to 111
:::danger[Update compose file]
You must change the values enclosed within curly brackets {} in the following compose file.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's obvious it needs changing? or good to have this warning?

- Your Rafiki instance must be set up for at least one asset before wallet addresses can be created as each wallet address must have an asset assigned to it.
- Wallet address URLs are treated as case-insensitive, meaning that both lowercase and uppercase variations of the same address will be recognized as identical.
:::
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::
:::

@hajjimo hajjimo requested a review from mkurapov October 17, 2024 12:16
Comment on lines +477 to +483
sudo ln -s /etc/nginx/sites-available/admin.conf /etc/nginx/sites-enabled/admin.conf

sudo ln -s /etc/nginx/sites-available/open_payments_auth_server.conf /etc/nginx/sites-enabled/auth.conf

sudo ln -s /etc/nginx/sites-available/ilp.conf /etc/nginx/sites-enabled/ilp.conf

sudo ln -s /etc/nginx/sites-available/open_payments_resource_server.conf /etc/nginx/sites-enabled/oprs.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should match the file names from above

@@ -160,6 +160,22 @@ The first retry is after 10 seconds. Additional retries occur after 20 more seco

#### Incoming payment created

<details>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change be here?

| auth | auth.DOMAIN | auth.myrafiki.com |
| connector | connector.DOMAIN | connector.myrafiki.com |
| ilp | ilp.DOMAIN | ilp.myrafiki.com |
### Install Docker Engine and Docker Compose plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just link to the docker engine install page? since it'll differ per distro
https://docs.docker.com/engine/install/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: documentation Changes in the documentation package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker compose files to Docker Compose section in docs
2 participants