Skip to content

fix: assume witness-enabled parsing for version > 2 #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nakul1010 merged 2 commits into from
Jun 25, 2025
Merged

fix: assume witness-enabled parsing for version > 2 #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c13c7fa
fix: assume witness-enabled parsing for version > 2
nakul1010 Jun 25, 2025
ab4136b
fix: clamp parse_with version to 2 for higher tx versions
nakul1010 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/bitcoin/src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,18 @@ pub fn parse_compact_uint(varint: &[u8]) -> Result<(u64, usize), Error> {
pub fn parse_transaction(raw_transaction: &[u8]) -> Result<Transaction, Error> {
let mut parser = BytesParser::new(raw_transaction);
let version: i32 = parser.parse()?;
// For version > 2, treat it as version 2 for parsing behavior
let effective_version = if version > 2 { 2 } else { version };

let allow_witness = (version & SERIALIZE_TRANSACTION_NO_WITNESS) == 0;
let allow_witness = (effective_version & SERIALIZE_TRANSACTION_NO_WITNESS) == 0;

// TODO: bound maximum?
let mut inputs: Vec<TransactionInput> = parser.parse_with(version)?;
let mut inputs: Vec<TransactionInput> = parser.parse_with(effective_version)?;

let mut flags: u8 = 0;
if inputs.is_empty() && allow_witness {
flags = parser.parse()?;
inputs = parser.parse_with(version)?;
inputs = parser.parse_with(effective_version)?;
}

// TODO: bound maximum?
Expand Down