Conversation
Member
|
@ipc103 I initially thought it would not work with lower than 2.3 also. |
|
Great to see this fixed soon. Thanks! Please also remember to update the change log. Last entry is for version 3.5.17... |
Member
|
@ipc103 @P9GIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358
CC: @choran - it seems that using the lonely operator (
&) breaks that method for anyone below Ruby 2.3 - sorry about that.Also, it seems that prior to 2.3,
JSON.parseraises an error when passed anullvalue, rather than just returningnil. To be consistent across Ruby versions, seems like it makes more sense to raise an application error if thedecoded_bodyis'null', no matter whatLet me know if this seems more sensible!