Skip to content

add nil check for parsed_body #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choran merged 1 commit into from
Oct 13, 2017
Merged

add nil check for parsed_body #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/intercom/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def parse_body(decoded_body, response)
rescue JSON::ParserError => _
raise_errors_on_failure(response)
end
raise_application_errors_on_failure(parsed_body, response.code.to_i) if parsed_body['type'] == 'error.list'
raise_application_errors_on_failure(parsed_body, response.code.to_i) if parsed_body&['type'] == 'error.list'
parsed_body
end

Expand Down
6 changes: 6 additions & 0 deletions spec/unit/intercom/request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,10 @@
req = Intercom::Request.new('path/', 'GET')
req.parse_body(nil, response).must_equal(nil)
end

it 'parse_body returns nil if the decoded_body is "null"' do
response = OpenStruct.new(:code => 500)
req = Intercom::Request.new('path/', 'GET')
req.parse_body('null', response).must_equal(nil)
end
end