Improve setup script with enhanced visual output and comprehensive testing #289
+263
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comprehensive test coverage
uddish
added
the
team-messenger-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/intercom/intercom/issues/407144
This pull request aims to significantly improve the user experience of our setup script by providing clearer, more informative, and visually appealing output during the installation process. The enhanced script now offers better progress tracking, error handling, and overall feedback, making it easier for end-users to understand and troubleshoot the setup process if needed.
The changes include the addition of step-by-step progress indicators, a visual progress bar, color-coded output for different types of messages (success, warnings, errors, and info), and timing information for the entire setup process. We've also implemented a more professional layout with structured borders and formatted sections. These improvements will help users better understand what's happening during the setup and provide a more polished experience.
In addition to the visual enhancements, we've added comprehensive test coverage for the setup script. A new test suite in
__tests__/setup.test.jsnow includes 11 test cases that cover all aspects of the improved script, ensuring its functionality, structure, and visual enhancements work as expected. Thepackage.jsonfile has been updated to use the proper Jest test command, and all tests are now passing. These changes will help maintain the script's reliability and make future modifications easier and safer.