Adding mapping for customer_first_reply#263
Merged
mmartinic merged 6 commits intointercom:masterfrom Dec 5, 2019
alexshultsg:dynatrace/customer_first_reply
Merged
Adding mapping for customer_first_reply#263mmartinic merged 6 commits intointercom:masterfrom alexshultsg:dynatrace/customer_first_reply
mmartinic merged 6 commits intointercom:masterfrom
alexshultsg:dynatrace/customer_first_reply
Conversation
Contributor
Author
mmartinic
reviewed
Dec 5, 2019
Contributor
mmartinic
left a comment
mmartinic
left a comment
There was a problem hiding this comment.
@alexshultsg I added a couple of small comments. Could you please make these changes? I can merge after that
Contributor
Author
|
@mmartinic Done, I also added a unit test. Thank you |
Contributor
|
@alexshultsg thanks! I'll take a look |
mmartinic
approved these changes
Dec 5, 2019
Contributor
Author
|
@mmartinic For some reason build are failing with some sort of permission error. could you, please, look at them? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
customer_first_reply filed is missing in Java API
How?
By adding mapping from json