Conversation
apassant
approved these changes
Oct 9, 2018
mmartinic
reviewed
Oct 9, 2018
| @@ -237,9 +237,6 @@ private HttpURLConnection prepareConnection(HttpURLConnection conn) { | |||
|
|
|||
| private Map<String, String> createAuthorizationHeaders() { | |||
| switch (Intercom.getAuthKeyType()) { | |||
Contributor
There was a problem hiding this comment.
If we're removing API_KEY we could also remove this whole switch and just run
headers.put("Authorization", "Basic " + generateAuthString(Intercom.getToken(),""));
We can then remove getAuthKeyType() in Intercom class and get rid of AuthKeyType enum altogether.
@thewheat wdyt?
Contributor
Author
There was a problem hiding this comment.
I had initial thoughts of keeping it here in case we could have future authentication methods but for simplification, the removal of getAuthKeyType and AuthKeyType makes sense too 👍 I'll get to it 😄
thewheat
force-pushed
the
timlim/remove-set-api-key
branch
from
556e888 to
99fe92c
Compare
mmartinic
reviewed
Oct 16, 2018
| private volatile AuthKeyType authKeyType = AuthKeyType.API_KEY; | ||
| private volatile String apiKey; | ||
| private volatile String token; | ||
| private volatile String appID; |
Contributor
There was a problem hiding this comment.
I think we can also remove appId here. It was used in conjunction with apiKey when generating the Auth header. Now we just need the token
thewheat
force-pushed
the
timlim/remove-set-api-key
branch
from
6c0a753 to
751af43
Compare
mmartinic
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
How?