Merged
Conversation
7cfce3f to
1c79aa6
Compare
1c79aa6 to
7dc5540
Compare
SeanHealy33
commented
Aug 7, 2018
| @@ -1,25 +1,43 @@ | |||
| #!/usr/bin/env bash | |||
| #!/usr/bin/env sh | |||
Contributor
Author
There was a problem hiding this comment.
This file is auto generated from gradle wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Gradle version is super super old 😰
Currently our circle ci file pulls the most recent version of
openJDKhttps://github.com/intercom/intercom-java/blob/master/.circleci/config.yml#L5
our
gradlewwrappers were generated over 4 years ago and do not support JDK 10.12 causing all our builds to fail seemingly randomly after a ReadMe.md commit.This update should allow our ci to start building the project again.