Conversation
SeanHealy33
reviewed
Aug 9, 2018
| assertEquals(null, plan.getName()); | ||
| assertEquals(1517835268, company.getUpdatedAt()); | ||
| assertEquals(0, company.getRemoteCreatedAt()); | ||
| // assertEquals(0, company.getLastRequestAt()); |
Contributor
There was a problem hiding this comment.
why are these commented out?
Contributor
Author
There was a problem hiding this comment.
Those don't exist yet until we merge #183 😄
So once that gets merge I'll update this PR
thewheat
force-pushed
the
timlim/company-tests
branch
2 times, most recently
from
b508617 to
dbba7bf
Compare
thewheat
force-pushed
the
timlim/company-tests
branch
from
dbba7bf to
6c78c0a
Compare
Contributor
Author
|
Updated and ready for another review 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated out from #183
Will wait for both #183 & #213 to be merged before finalising