Prioritise user_id over email in user tagging (Fixes: #197)#199
Merged
Prioritise user_id over email in user tagging (Fixes: #197)#199
Conversation
keloe
approved these changes
Jul 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #197
Tag.tag(tag, user);intercom-java/intercom-java/src/main/java/io/intercom/api/Tag.java
Lines 83 to 94 in f50c869
Current library would fail on this
Essentially the code above would create this API request
Instead of
Reshuffling so user_id has precendence over this it will fix it