Add support for new Admin endpoints and attributes (Closes: #196)#198
Add support for new Admin endpoints and attributes (Closes: #196)#198
Conversation
1410e42 to
bfa8715
Compare
bfa8715 to
3998441
Compare
| return DataResource.list(SENTINEL, "admins", AdminCollection.class); | ||
| } | ||
|
|
||
| public static Admin find(String id) |
There was a problem hiding this comment.
Do you think we need a quick test for the find?
Just wanted to check if you think this is needed or not
|
Yo Tim, I think it needs a readme update with some simple examples since you are adding the setting and finding options. If you have those handy it might be good to add them. I can merge it then. Alternatively if you dont have time we can merge it now and I can add readme examples later? The only comment was whether we needed a find test as well. |
|
@choran definitely agree with respect to the readme. If you're looking to do a release soon I think we should merge and add examples later. With regards to the tests on |
3998441 to
bb4738e
Compare
|
@choran updated readme 👍 |
Fixes: #196
Added