Conversation
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "id": 123456 | |||
| } No newline at end of file | |||
| private String intercom_user_id; | ||
| public UserPermanentDeleteRequest() { | ||
| } | ||
| public UserPermanentDeleteRequest(String intercom_user_id) { |
There was a problem hiding this comment.
Better naming to call intercom_user_id => intercomUserId?
There was a problem hiding this comment.
Ah yes thanks for catching that 👍
| @SuppressWarnings("UnusedDeclaration") | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | ||
| public class UserPermanentDeleteRequest { |
There was a problem hiding this comment.
I think this should be renamed to PermanentlyDeleteUserRequest.
| @SuppressWarnings("UnusedDeclaration") | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | ||
| public class UserPermanentDeleteResponse { |
There was a problem hiding this comment.
I think this should be renamed to PermanentlyDeleteUserResponse.
| /** | ||
| * @deprecated Replaced by {@link #archive(String)}. Renamed for consistency with API language | ||
| */ | ||
| public static User delete(String id){ |
There was a problem hiding this comment.
Thanks for the review @eripe970. Not sure I get exactly which formatting that you're referring to here so would be great if I could get a bit more details.
Will change some the issues that I've responded to but will leave the naming convention to the other dev teammates to take a look at 😄
There was a problem hiding this comment.
Cool, normally it's a space before the {, like delete(String id){ => delete(String id) {. At least I think that's the convention that is used in a lot of code-bases.
There was a problem hiding this comment.
Ah got it 👍 I do see the other files do have that space so added it in
thewheat
force-pushed
the
timlim/add-permanent-delete
branch
2 times, most recently
from
f32447b to
168dfff
Compare
thewheat
force-pushed
the
timlim/add-permanent-delete
branch
from
168dfff to
0ec24fc
Compare
|
Is it possible to do a new release that includes this PR @choran? |
|
@eripe970 looks like version 2.4.0 does contain the code in question
Also available in bintray (Updated on 8th June): https://bintray.com/intercom/intercom-maven/intercom-java/2.4.0
Updated my dependency in my local code and I am able to make a permanent deletion request 😄
|
|
Thanks! 👍 Missed that it was a new release out! |
3 participants
Add support for permanent deletion https://developers.intercom.com/reference#delete-users
Deprecate
deleteand replace it witharchive