Skip to content

Remove unnecessary type validation#171

Merged
choran merged 1 commit intomasterfrom
timlim/support-listing-all-conversation
Dec 19, 2017
Merged

Remove unnecessary type validation#171
choran merged 1 commit intomasterfrom
timlim/support-listing-all-conversation

Conversation

@thewheat
Copy link
Contributor

Addresses #163

Removes unnecessary type validation

image

Will enable calls like this

Map<String, String> params = Maps.newHashMap();
params.put("order", "asc"); // or "desc"
params.put("sort", "created_at"); // or "waiting_since" or "updated_at"
ConversationCollection conversations = Conversation.list(params);

Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange we were restrictive here with this.
Make sense 👍

@choran choran merged commit d532d33 into master Dec 19, 2017
@thewheat thewheat deleted the timlim/support-listing-all-conversation branch February 14, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants