Skip to content

add data_type for bulk user actions#129

Merged
mmartinic merged 1 commit intomasterfrom
MM/bulk_users
Nov 11, 2016
Merged

add data_type for bulk user actions#129
mmartinic merged 1 commit intomasterfrom
MM/bulk_users

Conversation

@mmartinic
Copy link
Contributor

@mmartinic mmartinic commented Nov 10, 2016

@mmartinic
Copy link
Contributor Author

mmartinic commented Nov 10, 2016

This adds data_type for user bulk job payload

{"items":[{"method":"post","data_type":"user","data":{"user_id":"13","custom_attributes":{"test_string":"from Java SDK BULK"}}}]}

We shouldn't skip response for 202 as response body contains job id in this case

buildFrom will create a data without type set as we don't need that. We have to copy data_type from original item.data

@mmartinic mmartinic force-pushed the MM/bulk_users branch 4 times, most recently from f35f108 to 8b63fca Compare November 11, 2016 11:48
Copy link
Contributor

@khalilovcmd khalilovcmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change to the access specifier of the constructor 👍

@mmartinic mmartinic merged commit a319457 into master Nov 11, 2016
@mmartinic mmartinic deleted the MM/bulk_users branch November 11, 2016 12:21
@choran choran mentioned this pull request Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants