Handle nil initial message in presentMessageComposer#345
Open
piwel wants to merge 1 commit intointercom:masterfrom
Open
Handle nil initial message in presentMessageComposer#345piwel wants to merge 1 commit intointercom:masterfrom
piwel wants to merge 1 commit intointercom:masterfrom
Conversation
Hi Intercom Cordova team, We’re seeing a reproducible crash on iOS whenever presentMessageComposer (or the deprecated displayMessageComposer) is invoked without an initial message. The bridge always indexes into command.arguments[0], but when Cordova sends an empty arguments array the call throws NSRangeException: Fatal Exception: NSRangeException -[IntercomBridge presentMessageComposer:] + IntercomBridge.m:175 -[NSArray objectAtIndexedSubscript:] Android avoids this by reading args.optString(0), but the iOS bridge doesn’t guard against command.arguments.count == 0 or an NSNull. This mirrors the Android behavior and prevents the crash for callers that don’t supply an initial message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Intercom Cordova team,
We’re seeing a reproducible crash on iOS whenever presentMessageComposer (or the deprecated displayMessageComposer) is invoked without an initial message. The bridge always indexes into command.arguments[0], but when Cordova sends an empty arguments array the call throws NSRangeException:
Fatal Exception: NSRangeException
-[IntercomBridge presentMessageComposer:] + IntercomBridge.m:175
-[NSArray objectAtIndexedSubscript:]
Android avoids this by reading args.optString(0), but the iOS bridge doesn’t guard against command.arguments.count == 0 or an NSNull.
This mirrors the Android behavior and prevents the crash for callers that don’t supply an initial message.