spec fixes for java sdk #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 14, 2025 11:03
tests now compile; # of failed tests 30 -> 10, by including correct offset paging when relevant and modifying some tests to match the current spec (see PR in fern-demo)
fixes typing of contact.avatar. when run with modified tests from fern-demo/intercom-java-sdk (currently branch gettin-tests-to-work), compiles and passes all tests
avoids the workflow doing a ton of API calls
dsinghvi
reviewed
Mar 14, 2025
| FERN_TOKEN: ${{ secrets.FERN_TOKEN }} | ||
| run: | | ||
| cd fern/.preview/fern-java-sdk | ||
| ./gradlew assemble |
There was a problem hiding this comment.
does assemble also call compileJava ?
There was a problem hiding this comment.
yes! it's all of:
":compileJava
:processResources
:classes
:jar
:javadoc
:javadocJar
:sourcesJar
:assemble"
fern-support
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.