Skip to content

fix: Hold running tasks within a Task, so the task doesn't get garbage collected before it completes #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
+4 −1
Open

fix: Hold running tasks within a Task, so the task doesn't get garbage collected before it completes #1790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion interactions/models/internal/tasks/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def _fire(self, fire_time: datetime, *args, **kwargs) -> asyncio.Task:

async def _task_loop(self, *args, **kwargs) -> None:
"""The main task loop to fire the task at the specified time based on triggers configured."""
running = set()
while not self._stop.is_set():
fire_time = self.trigger.next_fire()
if fire_time is None:
Expand All @@ -107,7 +108,9 @@ async def _task_loop(self, *args, **kwargs) -> None:
if future in done:
return None

self._fire(fire_time, *args, **kwargs)
task = self._fire(fire_time, *args, **kwargs)
running.add(task)
task.add_done_callback(running.discard)

def start(self, *args, **kwargs) -> None:
"""Start this task."""
Expand Down