fix: properly fix component/modal callback

[AstreaTSS]

Pull Request Type

• Feature addition
• Bugfix
• Documentation update
• Code refactor
• Tests improvement
• CI/CD pipeline enhancement
• Other: [Replace with a description]

Description

component_callback and modal_callback was always using the function name after the last patch due to some weirdness. This PR fixes that by simplifying the patch and... fixing parts of the patch itself, funny enough.

Frankly, I'm disappointed in myself how easy this fix was 😅.

Changes

• Pass in custom_id to the unpack helper/validator, not the empty resolved_custom_id.
• Removed the unused (other than for the mistake above) resolved_custom_id initial declaration - I think we all forgot that resolved_custom_id does not get passed into there without a nonlocal. No idea how custom_id does in this specific case, but it does.
  • Yes, this patch makes the code very similar to the code before the first patch. However, since the variable name inside the wrapper function is different from just custom_id, everything works now (for some reason).

Related Issues

Test Scenarios

@interactions.slash_command(name="test", description="My command")
async def test(ctx: interactions.SlashContext):
    await ctx.send(
        components=interactions.Button(
            style=interactions.ButtonStyle.PRIMARY, label="Test", custom_id="test"
        )
    )


@interactions.component_callback("test")
async def test_callback(ctx: interactions.ComponentContext):
    await ctx.edit_origin(content="Test")

Python Compatibility

• I've ensured my code works on Python 3.10.x
• I've ensured my code works on Python 3.11.x

Checklist

• I've run the pre-commit code linter over all edited files
• I've tested my changes on supported Python versions
• I've added tests for my code, if applicable
• I've updated / added documentation, where applicable

[silasary]

nonlocal was only needed because we were redefining a name used in a higher scope.

This is much nicer