Skip to content

Add await #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add await #152

merged 1 commit into from
Apr 14, 2021

Conversation

hrmorley34
Copy link
Contributor

About this pull request

Fix #151.

Changes

Added await in sync_all_commands for get_all_commands.

Checklist

  • I've checked this pull request runs on Python 3.6.X.
    • Works on 3.9; very small diff.
  • This fixes something in Issues.
  • This adds something new.
  • There is/are breaking change(s).
  • (If required) Relevant documentation has been updated/added.
  • This is not a code change. (README, docs, etc.)

@quirky-bluejay
Copy link
Contributor

LGTM, although it would be ideal if it was tested on 3.6, i don't think that's necessary in this case

@eunwoo1104 eunwoo1104 added the bug Something isn't working label Apr 14, 2021
@eunwoo1104
Copy link
Contributor

I completely forgot about this issue. Anyways, merging this pull request, thank you for contributing!

@eunwoo1104 eunwoo1104 merged commit 81af65f into interactions-py:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eunwoo1104 eunwoo1104 eunwoo1104 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing await in sync_all_commands
3 participants
@hrmorley34 @quirky-bluejay @eunwoo1104