Show diff failures for pre-commit CI workflow #1484

i0bs · 2023-07-14T06:08:33Z

Pull Request Type

Description

This PR proposes showing diffs on pre-commit failures, so we can have more verbosity and explicitness in seeing our issues. When we run $ git commit anyhow, we're performing a standard $ pre-commit run execution without --all-files or --show-diff-on-failure CLI flags present.

I rely on seeing the pre-commit CI status to check for any formatting and linting errors. We might want to see what was changed, in case there are recurring issues with deps working together as well, such as a lack of a profile for making flake8 and isort working together with black in the pre-commit config

Changes

Added the --show-diff-on-failure to the run step of our pre-commit CI workflow

Related Issues

Test Scenarios

Tests are done by allowing the CI workflow to run on an open PR, and seeing for potential formatting changes.

Python Compatibility

I've ensured my code works on Python 3.10.x
I've ensured my code works on Python 3.11.x

Checklist

I've run the pre-commit code linter over all edited files
I've tested my changes on supported Python versions
I've added tests for my code, if applicable
I've updated / added documentation, where applicable

codecov-commenter · 2023-07-14T06:10:25Z

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (bb34581) 58.39% compared to head (e665d5b) 58.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1484      +/-   ##
============================================
- Coverage     58.39%   58.31%   -0.08%     
============================================
  Files           143      143              
  Lines         15236    15236              
============================================
- Hits           8897     8885      -12     
- Misses         6339     6351      +12

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* feat: add args, kwargs to task (#1478) * modified: interactions/models/internal/tasks/task.py * reset to set_last_call_time Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> * feat: add id attr to app perms update event * revert: commit signoff err * ci: show pre-commit diff on failure (#1484) * feat: add alt methods for multi-arg params for prefixed cmds (#1471) * feat: add alt methods for multi-arg params for prefixed cmds * fix: use empty if the typehint is just tuple * ci: correct from checks. * fix: support ConsumeRest without typehint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: cache channel data from interactions (#1479) * fix: account for BaseChannel for channel mentions (#1480) * feat: add default to delete/edit init interaction msg (#1481) * docs: remove outdated cookiecutter template (#1483) * docs: remove outdated cookiecutter template * docs: add boilerplate mention * feat: add id attr to app perms update event (#1485) * feat: add sort order for forums (#1488) * feat: add forum sort order * feat: cache layout and sort order for forums * feat: add rate limit per user where needed (#1489) Signed-off-by: LordOfPolls <dev@lordofpolls.com> * fix: use message channel for PrefixedContext (#1491) * fix: bound app_permissions for HybridContext (#1492) * feat: add start_time(s) for AutoShardedClient (#1482) * feat: add start_time(s) for AutoShardedClient * feat: make start_times a dict * docs: make start_times docstring clearer Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: correct listen typehint (#1495) * chore: move mutable class ref/attrs to ClassVar typing (#1497) * ci: weekly check. (#1460) * ci: weekly check. updates: - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.272 → v0.0.278](astral-sh/ruff-pre-commit@v0.0.272...v0.0.278) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add ability to use different arg name than option name (#1493) * feat: add ability to use different arg name than option name * feat: raise better error if arg name doesnt exist * fix: use ValueError instead of TypeError TypeError seems to be suppressed * fix: make sure exported auto_defer is deco, not module (#1496) * fix/feat: adjust invite obj to respect event variants (#1500) * fix/feat: adjust invite obj to respect event variants * docs: update docs for event object * revert: keep MISSING for backwards compatibility * style: consistency Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: address issues with tag usage for guild forums (#1499) * fix: address issues with tags for guild forums * fix: is this breaking? better be safe than sorry * docs💥: revamp extension guide (#1494) * docs💥: revamp extension guide * docs: update extension example * docs: oops, forgot a word Co-authored-by: Max <maxyolo01.ytb@gmail.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> * docs: add section for loading all extensions in folder * docs: turns out ipy can load multi exts in one file * docs: lots of wording adjustments --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> * feat: add `guild` & `channel` properties to `ThreadMembersUpdate` (#1504) * ci: weekly check. (#1503) * ci: weekly check. updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.278 → v0.0.280](astral-sh/ruff-pre-commit@v0.0.278...v0.0.280) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(http): incorrect path for delete permission endpoint (#1506) * fix delete_permissions api endpoint fix API Endpoint in delete_channel_permission adding "permissions/" in Endpoint * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci: weekly check. (#1511) updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.281](astral-sh/ruff-pre-commit@v0.0.280...v0.0.281) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: Implement missing stuff for scheduled events (#1507) * feat: Implement gateway support for scheduled events * fix: add optional to user add/remove * refactor: pre-commit'ed * refactor: change attrs to props and add `attrs.field` * refactor: set repr to True * feat(client): add `get_scheduled_event` helper method * refactor: use cache helpers in methods * chore: replace typing * docs: clarify intents in example (#1516) * feat: infer modal/component callback names from coroutine (#1519) * feat: infer callback decor from coroutine name * docs: add new logic notation * chore: add doc notation to component callback definition * docs: clarify intents for extensions * ci: weekly check. (#1521) updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.281 → v0.0.282](astral-sh/ruff-pre-commit@v0.0.281...v0.0.282) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> Signed-off-by: LordOfPolls <dev@lordofpolls.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: kennhh <133614589+kennhh@users.noreply.github.com> Co-authored-by: i0bs <41456914+i0bs@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: Damego <damego.dev@gmail.com> Co-authored-by: Donbur4156 <janpfister@t-online.de>

* feat: add args, kwargs to task (#1478) * modified: interactions/models/internal/tasks/task.py * reset to set_last_call_time Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> * feat: add id attr to app perms update event * revert: commit signoff err * ci: show pre-commit diff on failure (#1484) * feat: add alt methods for multi-arg params for prefixed cmds (#1471) * feat: add alt methods for multi-arg params for prefixed cmds * fix: use empty if the typehint is just tuple * ci: correct from checks. * fix: support ConsumeRest without typehint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: cache channel data from interactions (#1479) * fix: account for BaseChannel for channel mentions (#1480) * feat: add default to delete/edit init interaction msg (#1481) * docs: remove outdated cookiecutter template (#1483) * docs: remove outdated cookiecutter template * docs: add boilerplate mention * feat: add id attr to app perms update event (#1485) * feat: add sort order for forums (#1488) * feat: add forum sort order * feat: cache layout and sort order for forums * feat: add rate limit per user where needed (#1489) Signed-off-by: LordOfPolls <dev@lordofpolls.com> * fix: use message channel for PrefixedContext (#1491) * fix: bound app_permissions for HybridContext (#1492) * feat: add start_time(s) for AutoShardedClient (#1482) * feat: add start_time(s) for AutoShardedClient * feat: make start_times a dict * docs: make start_times docstring clearer Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: correct listen typehint (#1495) * chore: move mutable class ref/attrs to ClassVar typing (#1497) * ci: weekly check. (#1460) * ci: weekly check. updates: - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.272 → v0.0.278](astral-sh/ruff-pre-commit@v0.0.272...v0.0.278) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add ability to use different arg name than option name (#1493) * feat: add ability to use different arg name than option name * feat: raise better error if arg name doesnt exist * fix: use ValueError instead of TypeError TypeError seems to be suppressed * fix: make sure exported auto_defer is deco, not module (#1496) * fix/feat: adjust invite obj to respect event variants (#1500) * fix/feat: adjust invite obj to respect event variants * docs: update docs for event object * revert: keep MISSING for backwards compatibility * style: consistency Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> * fix: address issues with tag usage for guild forums (#1499) * fix: address issues with tags for guild forums * fix: is this breaking? better be safe than sorry * docs💥: revamp extension guide (#1494) * docs💥: revamp extension guide * docs: update extension example * docs: oops, forgot a word Co-authored-by: Max <maxyolo01.ytb@gmail.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> * docs: add section for loading all extensions in folder * docs: turns out ipy can load multi exts in one file * docs: lots of wording adjustments --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> * feat: add `guild` & `channel` properties to `ThreadMembersUpdate` (#1504) * ci: weekly check. (#1503) * ci: weekly check. updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.278 → v0.0.280](astral-sh/ruff-pre-commit@v0.0.278...v0.0.280) * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(http): incorrect path for delete permission endpoint (#1506) * fix delete_permissions api endpoint fix API Endpoint in delete_channel_permission adding "permissions/" in Endpoint * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci: weekly check. (#1511) updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.281](astral-sh/ruff-pre-commit@v0.0.280...v0.0.281) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: Implement missing stuff for scheduled events (#1507) * feat: Implement gateway support for scheduled events * fix: add optional to user add/remove * refactor: pre-commit'ed * refactor: change attrs to props and add `attrs.field` * refactor: set repr to True * feat(client): add `get_scheduled_event` helper method * refactor: use cache helpers in methods * chore: replace typing * chore: pyproject version bump --------- Signed-off-by: kennhh <133614589+kennhh@users.noreply.github.com> Signed-off-by: LordOfPolls <dev@lordofpolls.com> Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Signed-off-by: Sophia <41456914+i0bs@users.noreply.github.com> Co-authored-by: kennhh <133614589+kennhh@users.noreply.github.com> Co-authored-by: i0bs <41456914+i0bs@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: LordOfPolls <dev@lordofpolls.com> Co-authored-by: Max <maxyolo01.ytb@gmail.com> Co-authored-by: Damego <damego.dev@gmail.com> Co-authored-by: Donbur4156 <janpfister@t-online.de>

ci: show pre-commit diff on failure

e665d5b

i0bs changed the base branch from stable to unstable July 14, 2023 06:08

LordOfPolls approved these changes Jul 14, 2023

View reviewed changes

i0bs merged commit c5c5045 into unstable Jul 14, 2023

i0bs deleted the ci-precommit-diff branch July 14, 2023 21:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show diff failures for pre-commit CI workflow #1484

Show diff failures for pre-commit CI workflow #1484

Uh oh!

i0bs commented Jul 14, 2023

Uh oh!

codecov-commenter commented Jul 14, 2023 •

edited

Loading

Uh oh!

Uh oh!

Show diff failures for pre-commit CI workflow #1484

Show diff failures for pre-commit CI workflow #1484

Uh oh!

Conversation

i0bs commented Jul 14, 2023

Pull Request Type

Description

Changes

Related Issues

Test Scenarios

Python Compatibility

Checklist

Uh oh!

codecov-commenter commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

codecov-commenter commented Jul 14, 2023 •

edited

Loading