fix: Correctly handle race condition if voice keepalive procs while reconnecting #1449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
During Voice reconnect, we briefly set the websocket to None: https://github.com/interactions-py/interactions.py/blob/stable/interactions/api/voice/voice_gateway.py#L222-L236
If the keepalive triggers during that await, self.ws is None, and we get a lovely error.
Changes
Do a null check before checking self.ws.connected
Related Issues
https://canary.discord.com/channels/789032594456576001/1095994644929708083/1118804300357967872
https://github.com/interactions-py/interactions.py/actions/runs/5285126118/jobs/9563299904
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files