Skip to content

fix: Don't apply guild_id to messages fetched from DM history #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

fix: Don't apply guild_id to messages fetched from DM history #1424

merged 1 commit into from
May 26, 2023

Conversation

silasary
Copy link
Member

@silasary silasary commented May 26, 2023 •
edited
Loading

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

DM channels don't have a guild ID.

Changes

  • Added type check before copying guild_id.
  • Added test case

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary changed the base branch from stable to unstable May 26, 2023 07:01
@LordOfPolls LordOfPolls merged commit 913a6f8 into unstable May 26, 2023
@LordOfPolls LordOfPolls deleted the dm_history branch May 26, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordOfPolls LordOfPolls LordOfPolls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silasary @LordOfPolls