Skip to content

feat: add component property to ComponentContext #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2023
Merged

feat: add component property to ComponentContext #1371

merged 4 commits into from
May 2, 2023

Conversation

GeomKid
Copy link
Contributor

@GeomKid GeomKid commented May 2, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Reimplementing PR #1268

Changes

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

Damego
Damego requested changes May 2, 2023
View reviewed changes
@Damego Damego changed the base branch from stable to unstable May 2, 2023 04:24
@Damego Damego changed the title Feat add component to property feat: add component property to ComponentContext May 2, 2023
Damego
Damego approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@Damego Damego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Wolfhound905
Wolfhound905 suggested changes May 2, 2023
View reviewed changes
Copy link
Contributor

@Wolfhound905 Wolfhound905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The component that you interacted."

Please fix this grammatical error. I think you meant:
"The component that was interacted with."

@GeomKid
Copy link
Contributor Author

GeomKid commented May 2, 2023

The component that was interacted with

fixed :)

@LordOfPolls LordOfPolls merged commit 7c00cff into interactions-py:unstable May 2, 2023
@GeomKid GeomKid deleted the feat-add-component-to-property branch May 3, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordOfPolls LordOfPolls LordOfPolls approved these changes

@Damego Damego Damego approved these changes

+1 more reviewer

@Wolfhound905 Wolfhound905 Wolfhound905 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeomKid @LordOfPolls @Damego @Wolfhound905