Skip to content

Conversation

artem30801
Copy link
Contributor

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

SlashCommand.group() now pases parent default_member_permissions (like .subcommand() does) to prevent conflicts and errors during synchonisation (couldn't use SlashCommand.group() when the parent command had default_member_permissions because of that).

Test Scenarios

test_cmd = interactions.SlashCommand(
    name="test",
    description="test",
    default_member_permissions=interactions.Permissions.ADMINISTRATOR,
)

test_grp = test_cmd.group("group", "test group")

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@artem30801 artem30801 changed the base branch from stable to unstable May 1, 2023 08:17
@LordOfPolls LordOfPolls merged commit 800cdc1 into interactions-py:unstable May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants