test require statements now work on case-sensitive platforms #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for fixing this 😄 |
brenoferreira
added a commit
that referenced
this pull request
Aug 14, 2015
test require statements now work on case-sensitive platforms
|
np. Thanks for the great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! Thanks for the awesome library - its been a godsend in a project I'm working on. I ran into a small problem, though - we're using immutablediff both client-side and server-side, and while OSX isn't case-sensitive, other OSs (notably Ubuntu in this case) are. Most of the tests had
require('Immutable')instead ofrequire('immutable')in them, and that was causing some problems in deployment. Hope you don't mind the quick fix PR :)