wqupdate xdnn and pack to support fp8 gemm in prefill #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenmao
force-pushed
the
perf/e4m3/pack
branch
2 times, most recently
from
f576f44 to
05e32c8
Compare
abenmao
force-pushed
the
perf/e4m3/pack
branch
2 times, most recently
from
a9c7641 to
b4a4193
Compare
a3213105
reviewed
Jul 21, 2025
src/utils/matmul_helper.h
Outdated
| int amx_cols = (int)((N + 63) / 64) * 64; | ||
| if (!weight.isShadow()) weight.Resize(amx_rows, amx_cols); | ||
| memset(weight.Data(), 0, sizeof(e4m3_t) * amx_rows * amx_cols); | ||
| int blockSize = 32; |
Contributor
There was a problem hiding this comment.
Rename blockSize to packedBlockSize to avoid potential naming conflicts with blocksize in the future "assert(blockSize == 128);"
a3213105
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.