[Layers] fix assert bug when concat gate&up #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenmao
force-pushed
the
bugfix/layers/mlp
branch
3 times, most recently
from
073055c to
ad6c2c4
Compare
abenmao
force-pushed
the
bugfix/layers/mlp
branch
from
ad6c2c4 to
c47ae2d
Compare
Duyi-Wang
changed the title
pujiang2018
reviewed
Apr 18, 2024
| add_definitions(-DUSE_SHM=true) | ||
| option(XFT_BUILD_TESTS "Build xfastertransformer unit tests" OFF) | ||
| if(XFT_BUILD_TESTS) | ||
| add_definitions(-DUNDEBUG=true) |
Contributor
There was a problem hiding this comment.
why do we need UNDEBUG?
Contributor
Author
There was a problem hiding this comment.
When we use CMake release, the -DNDEBUG flag is included by default. This option would make all assert statements ineffective as one kind of optimization. I undefine this flag during unit testing (ut) to ensure that assert performs the necessary checks.
Contributor
Author
There was a problem hiding this comment.
This is also why in some environments the assert may fail, while in others it does not. The behavior of assert can vary depending on the compilation settings and the specific conditions.
Duyi-Wang
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.