Add KVCache trans for long sequence && tuned comm for faster Addreduce #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenmao
force-pushed
the
perf/comm/kvcache
branch
from
4cfb6d9 to
99731f4
Compare
abenmao
changed the title
pujiang2018
reviewed
Mar 29, 2024
|
|
||
| /** | ||
| * Tensor specially designed for KV Cache | ||
| * Naturaly, it could be represented in the shape of [seq_length][batch_size][head_num][head_size] |
Contributor
There was a problem hiding this comment.
Please also modify the comments here?
Contributor
Author
There was a problem hiding this comment.
Done~ New layout default disabled.
src/models/env_config.cpp
Outdated
| static int kvTrans = -1; | ||
| if (kvTrans == -1) { | ||
| kvTrans = (getenv("ENABLE_KV_TRANS") ? atoi(getenv("ENABLE_KV_TRANS")) : 0); | ||
| // if (kvTrans == 1) |
Contributor
There was a problem hiding this comment.
please remove it if not used.
Contributor
Author
There was a problem hiding this comment.
Added some comments.
| return catMlp == 1; | ||
| } | ||
|
|
||
| bool tunedComm() { |
Contributor
There was a problem hiding this comment.
it is not so easy to understand "Tuned communication". add some comment?
abenmao
force-pushed
the
perf/comm/kvcache
branch
2 times, most recently
from
9dd2a0f to
fc3e8ff
Compare
abenmao
force-pushed
the
perf/comm/kvcache
branch
from
fc3e8ff to
5da8280
Compare
pujiang2018
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpose KVCache with env var "ENABLE_KV_TRANS" for long sequence
Tune addreduce between shm and ccl for faster comm