[Layer] Convert static MMHelper class to instance Class in DecoderContext. #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pujiang2018
reviewed
Feb 19, 2024
Contributor
pujiang2018
left a comment
pujiang2018
left a comment
There was a problem hiding this comment.
Guess the performance and accuracy not impacted, but let's confirm it before merge.
| float sumVal[batchSize * numBeams] = {0}; | ||
| float sumVal[batchSize * numBeams]; | ||
| for (int i = 0; i < batchSize * numBeams; ++i) { | ||
| sumVal[i] = 0.0f; |
Contributor
There was a problem hiding this comment.
Original float "sumVal[batchSize * numBeams] = {0};" should work.
Contributor
Author
There was a problem hiding this comment.
Yes, original code could work, but this is c++20 standard. If we want to build w/ ICX, it should be c++17 standard.
| float maxVal[batchSize * numBeams] = {std::numeric_limits<float>::lowest()}; | ||
| float maxVal[batchSize * numBeams]; | ||
| for (int i = 0; i < batchSize * numBeams; ++i) { | ||
| maxVal[i] = std::numeric_limits<float>::lowest(); |
Contributor
There was a problem hiding this comment.
I guess the author intended to set all values to lowest float. good fix.
Contributor
Author
There was a problem hiding this comment.
Yes, original code could work, but this is c++20 standard. If we want to build w/ ICX, it should be c++17 standard.
pujiang2018
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.