libsafec: wmemset_s.c scilence compilation warning #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can safely cast wchar_t * to uint32_t in this case, in order to silence the
following warning:
safeclib/wmemset_s.c: In function ‘wmemset_s’:
safeclib/wmemset_s.c:101:20: warning: pointer targets in passing argument 1 of ‘mem_prim_set32’ differ in signedness [-Wpointer-sign]
mem_prim_set32(dest, len, value);
^~~~
In file included from safeclib/wmemset_s.c:34:
safeclib/mem_primitives_lib.h:71:1: note: expected ‘uint32_t *’ {aka ‘unsigned int *’} but argument is of type ‘wchar_t *’ {aka ‘int *’}
mem_prim_set32(uint32_t *dest, uint32_t dmax, uint32_t value);
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
|
Fixes: #23 (comment) |
dmwheel1
approved these changes
Aug 18, 2019
|
Thanks! |
xianju6x
pushed a commit
to xianju6x/safestringlib
that referenced
this pull request
Apr 23, 2020
libsafec: wmemset_s.c scilence compilation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely cast wchar_t * to uint32_t in this case, in order to silence the
following warning:
safeclib/wmemset_s.c: In function ‘wmemset_s’:
safeclib/wmemset_s.c:101:20: warning: pointer targets in passing argument 1 of ‘mem_prim_set32’ differ in signedness [-Wpointer-sign]
mem_prim_set32(dest, len, value);
^~~~
In file included from safeclib/wmemset_s.c:34:
safeclib/mem_primitives_lib.h:71:1: note: expected ‘uint32_t *’ {aka ‘unsigned int *’} but argument is of type ‘wchar_t *’ {aka ‘int *’}
mem_prim_set32(uint32_t *dest, uint32_t dmax, uint32_t value);
Signed-off-by: Tomas Winkler tomas.winkler@intel.com