Repository navigation
Interface struct - #672
Draft
desmonddak wants to merge 16 commits into
Draft
Interface struct#672desmonddak wants to merge 16 commits into
desmonddak wants to merge 16 commits into
Conversation
desmonddak
marked this pull request as draft
July 15, 2026 23:15
Exact cumulative tree from original branch 494c892f5a7ee843885188c794226ef20ec2de71 in the netlist-first merge order.
- Module: add portGroups map and registerPortGroup() API - Interface.connectIO: detect group name from uniquify function, register each port with its interface group - PairInterface: pass groupName through to super.connectIO and sub-interface connections Enables downstream synthesis/tools to identify which ports belong to the same logical interface without relying on naming heuristics.
…addInterfacePorts When asStruct=true, interface ports are registered as LogicStructure ports (prefix_in / prefix_out) instead of individual leaf ports. Backward compatible: default asStruct=false preserves existing behavior.
Restore the unified interface APIs and their structured-port netlist connectivity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
desmonddak
force-pushed
the
interface_struct
branch
from
October 11, 2026 13:00
fc611db to
465cf2e
Compare
Signed-off-by: Desmond A. Kirkpatrick <desmond.a.kirkpatrick@intel.com>
Signed-off-by: Desmond A. Kirkpatrick <desmond.a.kirkpatrick@intel.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
When we add
Interfaces toModules, we loop through them to flattenLogicStructures (hierarchically) and add individualPorts for each signal.A novel and compact way is instead to split the
Interfaceinto twoLogicStructures, one for input and one for output, and then add those two asPorts for theModule. For connectivityModules where anInterfaceor a subset of theInterfaceis consistently handed through to other subblocks, we see a dramatic decrease in complexity of wiring.Related Issue(s)
None.
Testing
This was tested on large, complex designs. Missing, however, are directed tests at corner cases to make sure this capability works in all use cases.
Backwards-compatibility
No. This adds a new way of adding interfaces to modules, but the old way is retained.
Documentation
No. Likely we need to provide an example and a description. A proposal may be to create a matrix of methods to add
Ports toModules and include this method.