-
Notifications
You must be signed in to change notification settings - Fork 75
Issue#334: Added enable signal to flipflop #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#334: Added enable signal to flipflop #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this! This has been a requested feature from multiple users.
A few notes on the implementation, but the tests look great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more tiny things, but looks great other than that!
Also, great job on testing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for the contribution!
Description & Motivation
It would be nice to have an enable signal optionally provided as part of the built-in FlipFlop as per #334
Testing
Update test/flop_test.dart for the same.
Documentation
Update required at official documentation. Not included by me.