Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Test failures via Logger #28

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Nov 22, 2022

Description & Motivation

  • Sub-components now accessible in Components
  • The check phase now runs synchronously at the end of the Test rather than triggered through the ROHD Simulator, giving greater control when handling error conditions.
  • Added printLevel to control printing independently of Logger level, which can also disable failures/kills.
  • Made handling of test failures/kills more robust and easier to handle.
  • Fixed a bug where Logger subscriptions could persist across tests.
  • Added more Test tests to cover these areas.
  • Fixed a bug where failures reported via the Logger and found during check phase would sometimes not cause a test to fail.

Related Issue(s)

None

Testing

Added new testing, and existing tests pass

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No, shouldn't be

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

@mkorbel1 mkorbel1 merged commit 40f2f27 into intel:main Nov 28, 2022
@mkorbel1 mkorbel1 deleted the testfails branch November 28, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant